Validate CMIP6 lat/lons against CMIP6-specific BBOX #494
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I set this to draft mode since the work @charparr is doing to receive the per-coverage BBOX(es) from Zeus, and validate lat/lons against those BBOX(es), make this PR's hard-coded BBOX technique outdated. I'll keep this PR around (in draft mode) until the dynamic-BBOX functionality is ready & merged, just in case we need a quick fix approach before Q4 2024 / Q1 2025 launch. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR validates lat/lon coordinates for CMIP6-based endpoints against a CMIP6-specific BBOX, which includes everything above ~49.95 latitude. Without this change, CMIP6 endpoints were being validated against the same Alaska-centric East/West BBOXes as the other endpoints, which is just a small subset of the CMIP6 extent.
To test, verify that the following example URLs return data:
http://localhost:5000/indicators/cmip6/point/85/175
http://localhost:5000/cmip6/point/85/175?vars=tas,pr
And also verify that the following two URLs return an error page describing the valid CMIP6 BBOX:
http://localhost:5000/indicators/cmip6/point/30/175
http://localhost:5000/cmip6/point/30/175
@charparr, I'm tagging you for this review since (if memory serves) you were working on an overhaul of the BBOX validation error page recently, and I want to make sure this doesn't conflict with your work. Feel free to modify this PR as needed if so!